Add Hello World by JakeIV · Pull Request #36 · gdscports/react-snake

JakeIV · 2022-10-19T15:50:39Z

Checklist ✅

Have you checked to see whether there are any conflicting / similar PRs already open?
Does your PR add any new tests
Does your PR pass all existing & new tests
Does your PR pass the linter?

What does this PR do? 🤔

Screenshots / Videos 📸

web/src/App.tsx

github-actions · 2022-10-19T15:51:07Z

web/src/App.tsx

 import IncrementButton from './IncrementButton';

+function helloWorld(){
+  console.log("Hello World")


🚫 [eslint] <quotes> _{reported by reviewdog 🐶}
Strings must use singlequote.

Suggested change

console.log("Hello World")

console.log('Hello World')

github-actions · 2022-10-19T15:51:08Z

web/src/App.tsx

 import IncrementButton from './IncrementButton';

+function helloWorld(){
+  console.log("Hello World")


🚫 [eslint] <semi> _{reported by reviewdog 🐶}
Missing semicolon.

Suggested change

console.log("Hello World")

console.log("Hello World");

github-actions · 2022-10-19T15:51:08Z

web/src/App.tsx

+  console.log("Hello World")
+}
+
+helloWorld()


🚫 [eslint] <semi> _{reported by reviewdog 🐶}
Missing semicolon.

Suggested change

helloWorld()

helloWorld();

web/src/App.tsx

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…orts/react-snake into feature/JakeIV/snakeGameHW

github-actions · 2022-10-19T16:01:22Z

web/src/App.tsx

+class SnakeEngine{
+


🚫 [eslint] <padded-blocks> _{reported by reviewdog 🐶}
Block must not be padded by blank lines.

Suggested change

class SnakeEngine{

class SnakeEngine{

web/src/App.tsx

github-actions · 2022-10-19T16:01:23Z

web/src/App.tsx

+class SnakeEngine{
+
+  static helloWorld(){
+    console.log("Hello World")


🚫 [eslint] <semi> _{reported by reviewdog 🐶}
Missing semicolon.

Suggested change

console.log("Hello World")

console.log("Hello World");

web/src/App.tsx

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions · 2022-10-19T16:05:33Z

web/src/App.tsx

+class SnakeEngine{
+


🚫 [eslint] <padded-blocks> _{reported by reviewdog 🐶}
Block must not be padded by blank lines.

Suggested change

class SnakeEngine{

class SnakeEngine

github-actions · 2022-10-19T16:05:33Z

web/src/App.tsx

 import reactLogo from './assets/react.svg';
 import IncrementButton from './IncrementButton';

+class SnakeEngine{


🚫 [eslint] <space-before-blocks> _{reported by reviewdog 🐶}
Missing space before opening brace.

Suggested change

class SnakeEngine{

class SnakeEngine {

github-actions · 2022-10-19T16:05:33Z

web/src/App.tsx


+class SnakeEngine{
+
+  static helloWorld(){


🚫 [eslint] <space-before-blocks> _{reported by reviewdog 🐶}
Missing space before opening brace.

Suggested change

static helloWorld(){

static helloWorld() {

web/src/App.tsx

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions · 2022-10-19T16:05:52Z

web/src/App.tsx

+class SnakeEngine{
+


🚫 [eslint] <padded-blocks> _{reported by reviewdog 🐶}
Block must not be padded by blank lines.

Suggested change

class SnakeEngine{

class SnakeEngine

github-actions · 2022-10-19T16:05:52Z

web/src/App.tsx

 import reactLogo from './assets/react.svg';
 import IncrementButton from './IncrementButton';

+class SnakeEngine{


🚫 [eslint] <space-before-blocks> _{reported by reviewdog 🐶}
Missing space before opening brace.

Suggested change

class SnakeEngine{

class SnakeEngine {

github-actions · 2022-10-19T16:05:52Z

web/src/App.tsx

+class SnakeEngine{
+
+  static helloWorld() {
+    console.log('Hello World')


🚫 [eslint] <semi> _{reported by reviewdog 🐶}
Missing semicolon.

Suggested change

console.log('Hello World')

console.log('Hello World');;

github-actions · 2022-10-19T16:05:58Z

web/src/App.tsx

+class SnakeEngine {
+


🚫 [eslint] <padded-blocks> _{reported by reviewdog 🐶}
Block must not be padded by blank lines.

Suggested change

class SnakeEngine {

class SnakeEngine {

github-actions · 2022-10-19T16:05:58Z

web/src/App.tsx

+class SnakeEngine {
+
+  static helloWorld() {
+    console.log('Hello World')


🚫 [eslint] <semi> _{reported by reviewdog 🐶}
Missing semicolon.

Suggested change

console.log('Hello World')

console.log('Hello World');;

…orts/react-snake into feature/JakeIV/snakeGameHW

github-actions · 2022-10-19T16:16:10Z

web/src/App.tsx

-
 import reactLogo from './assets/react.svg';
 import IncrementButton from './IncrementButton';
+import {SnakeEngine} from './SnakeEngine/SnakeEngine';


🚫 [eslint] <object-curly-spacing> _{reported by reviewdog 🐶}
A space is required after '{'.

Suggested change

import {SnakeEngine} from './SnakeEngine/SnakeEngine';

import { SnakeEngine} from './SnakeEngine/SnakeEngine';

web/src/App.tsx

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions · 2022-10-19T16:56:08Z

web/src/App.tsx

-
 import reactLogo from './assets/react.svg';
 import IncrementButton from './IncrementButton';
+import {SnakeEngine } from './SnakeEngine/SnakeEngine';


🚫 [eslint] <object-curly-spacing> _{reported by reviewdog 🐶}
A space is required after '{'.

Suggested change

import {SnakeEngine } from './SnakeEngine/SnakeEngine';

import { SnakeEngine } from './SnakeEngine/SnakeEngine';

JavaRip · 2022-10-23T13:33:44Z

Great start, please merge main into this branch to resolve conflicts then will approve

Thanks!

JavaRip

Great work! Merge main into branch to resolve conflicts then can approve

…orts/react-snake into feature/JakeIV/snakeGameHW

JakeIV and others added 2 commits October 19, 2022 16:40

Add Hello World

d388e41

Improvement, helloWorld into its own class

768b3ca

github-actions bot reviewed Oct 19, 2022

View reviewed changes

Change " to '

e60bca5

github-actions bot reviewed Oct 19, 2022

View reviewed changes

web/src/App.tsx Outdated Show resolved Hide resolved

JakeIV and others added 3 commits October 19, 2022 16:55

Update web/src/App.tsx

a185da3

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update web/src/App.tsx

9c7b319

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Merge branch 'feature/JakeIV/snakeGameHW' of https://github.com/gdscp…

e4d02b9

…orts/react-snake into feature/JakeIV/snakeGameHW

github-actions bot reviewed Oct 19, 2022

View reviewed changes

Jonas-Oppong and others added 4 commits October 19, 2022 17:04

Update web/src/App.tsx

492bf8e

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update web/src/App.tsx

94e3f88

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update web/src/App.tsx

627d83f

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update web/src/App.tsx

47315b7

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Oct 19, 2022

View reviewed changes

Update web/src/App.tsx

83404cc

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Oct 19, 2022

View reviewed changes

Jonas-Oppong and others added 5 commits October 19, 2022 17:06

Merge branch 'main' into feature/JakeIV/snakeGameHW

725f79b

Created SnakeEngine.ts

9189789

fixed linting

109a849

Merge branch 'feature/JakeIV/snakeGameHW' of https://github.com/gdscp…

79e644a

…orts/react-snake into feature/JakeIV/snakeGameHW

change

a1c0b5e

github-actions bot reviewed Oct 19, 2022

View reviewed changes

JakeIV and others added 4 commits October 19, 2022 17:27

formatted

19591d0

Update App.tsx

f3d6c9b

Added board and snake 🐍

91fa84a

Update web/src/App.tsx

7f86b88

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Oct 19, 2022

View reviewed changes

Update App.tsx

bfe0ce8

JavaRip self-requested a review October 23, 2022 13:33

JavaRip requested changes Oct 23, 2022

View reviewed changes

Jonas-Oppong and others added 8 commits October 24, 2022 12:53

Update App.tsx

0dcea24

Merge branch 'feature/JakeIV/snakeGameHW' of https://github.com/gdscp…

f208694

…orts/react-snake into feature/JakeIV/snakeGameHW

Merge branch 'feature/JakeIV/snakeGameHW' of https://github.com/gdscp…

4759ca5

…orts/react-snake into feature/JakeIV/snakeGameHW

Added controller

bf209ee

Merge branch 'feature/JakeIV/snakeGameHW' of https://github.com/gdscp…

b96bf82

…orts/react-snake into feature/JakeIV/snakeGameHW

Snake Now moves

59ce233

Merge branch 'feature/JakeIV/snakeGameHW' of https://github.com/gdscp…

de3ab61

…orts/react-snake into feature/JakeIV/snakeGameHW

Merge branch 'feature/JakeIV/snakeGameHW' of https://github.com/gdscp…

af7bc53

…orts/react-snake into feature/JakeIV/snakeGameHW

lewisclark mentioned this pull request Oct 30, 2022

[New Feature]: Controller / direction input 🎮 #39

Open

lewisclark linked an issue Oct 30, 2022 that may be closed by this pull request

[New Feature]: Controller / direction input 🎮 #39

Open

Jonas-Oppong and others added 16 commits November 9, 2022 13:06

View prototype

1f25614

prototype board code

88a5863

V4

c94305c

AddToBoard

cd80df1

UpdateBoard

16d5ca0

Updated View

37af233

Main SudoCode

1d3b96d

Main Loop v1

daef122

generates board every time it is viewed

0548532

generation v2

c2370ff

Error fix, with coords printed to console.

1154a3a

Board Wrapping Added and console cleared in view

6cd8d7f

added new lines

e2f5afb

food

6d273b0

Added Food

ac4e0c5

Added arrow key control

4974d87

	import {SnakeEngine} from './SnakeEngine/SnakeEngine';
	import { SnakeEngine} from './SnakeEngine/SnakeEngine';

	import {SnakeEngine } from './SnakeEngine/SnakeEngine';
	import { SnakeEngine } from './SnakeEngine/SnakeEngine';

Conversation

JakeIV commented Oct 19, 2022

Checklist ✅

What does this PR do? 🤔

Screenshots / Videos 📸

Uh oh!

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

JavaRip commented Oct 23, 2022

Uh oh!

JavaRip left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants